src/trusted/service_runtime/sel_validate_image.c - Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/sel_validate_image.c

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Trivial fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/service_runtime/elf_util.c ('K') | « src/trusted/service_runtime/elf_util.c ('k') | src/trusted/service_runtime/sys_memory.c » ('j') | src/trusted/service_runtime/sys_memory.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/service_runtime/sel_validate_image.c

diff --git a/src/trusted/service_runtime/sel_validate_image.c b/src/trusted/service_runtime/sel_validate_image.c

index 24c686f506ee0b52bfab01d696ef49a1284d7ae0..12325fa1cf5b60dc5535a87b80182cea1a2b7682 100644

--- a/src/trusted/service_runtime/sel_validate_image.c

+++ b/src/trusted/service_runtime/sel_validate_image.c

@@ -73,6 +73,7 @@ int NaClValidateCode(struct NaClApp *nap, uintptr_t guest_addr,

allowable HLTs. */

status = validator->Validate(guest_addr, data, size,

TRUE, /* stub out */

+ nap->pnacl_mode,

Petr Hosek 2015/07/28 19:05:46 This will become `nap->pnacl_mode ? DISABLE_UNSUPP

ruiq 2015/07/28 21:34:56 Done.

FALSE, /* text is not read-only */

nap->cpu_features,

metadata,

@@ -83,6 +84,7 @@ int NaClValidateCode(struct NaClApp *nap, uintptr_t guest_addr,

int readonly_text = nap->fixed_feature_cpu_mode;

status = validator->Validate(guest_addr, data, size,

FALSE, /* do not stub out */

+ nap->pnacl_mode,

Petr Hosek 2015/07/28 19:05:46 ditto

ruiq 2015/07/28 21:34:56 Done.

readonly_text,

nap->cpu_features,

metadata,