src/trusted/validator/ncvalidate.h - Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/ncvalidate.h

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Trivial fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/driver/ncval.cc ('K') | « src/trusted/validator/driver/ncval.cc ('k') | src/trusted/validator/validation_cache_test.cc » ('j') | src/trusted/validator/validation_pnacl_mode_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/ncvalidate.h

diff --git a/src/trusted/validator/ncvalidate.h b/src/trusted/validator/ncvalidate.h

index 31f55e454166a8982282c46f7f8615e4a115e698..6c34b2d783ea9d5b1741251f8ace84933cb302c9 100644

--- a/src/trusted/validator/ncvalidate.h

+++ b/src/trusted/validator/ncvalidate.h

@@ -63,6 +63,7 @@ typedef NaClValidationStatus (*NaClValidateFunc)(

uint8_t *data,

size_t size,

int stubout_mode,

+ int pnacl_mode,

Petr Hosek 2015/07/28 19:05:46 We've discussed this with bradnelson and gdeepti a

ruiq 2015/07/28 21:34:55 Done.

int readonly_text,

const NaClCPUFeatures *cpu_features,

const struct NaClValidationMetadata *metadata,