Source/core/svg/SVGAngle.idl - Issue 1234383003: Removing TreatNullAs=NullString from SVGAngle.valueAsString and SVGLength.valueAsString attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAngle.idl

Issue 1234383003: Removing TreatNullAs=NullString from SVGAngle.valueAsString and SVGLength.valueAsString attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reviewed: 1 Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGAngle.idl

diff --git a/Source/core/svg/SVGAngle.idl b/Source/core/svg/SVGAngle.idl

index 4c02f716d2b4a0236ac34adbda491e4dc4524d76..12320a3a07df9fd5275d9bdf4629c5f8c11a22d9 100644

--- a/Source/core/svg/SVGAngle.idl

+++ b/Source/core/svg/SVGAngle.idl

@@ -22,7 +22,6 @@

// http://www.w3.org/TR/SVG2/types.html#InterfaceSVGAngle

-// TODO(philipj): SVGAngle should have constructors. crbug.com/366541

philipj_slow 2015/07/20 11:47:02 Please restore this TODO, it wasn't fixed.

Paritosh Kumar 2015/07/20 12:15:02 Restored. Actually, I removed this after seeing ht

philipj_slow 2015/07/20 13:04:53 I see. You can remove them again if you mention it

[

ImplementedAs=SVGAngleTearOff,

SetWrapperReferenceTo(SVGElement contextElement),

@@ -39,8 +38,7 @@

readonly attribute unsigned short unitType;

[RaisesException=Setter] attribute float value;

[RaisesException=Setter] attribute float valueInSpecifiedUnits;

- // TODO(philipj): valueAsString should not have [TreatNullAs=NullString].

- [TreatNullAs=NullString, RaisesException=Setter] attribute DOMString valueAsString;

+ [RaisesException=Setter] attribute DOMString valueAsString;

[RaisesException] void newValueSpecifiedUnits(unsigned short unitType, float valueInSpecifiedUnits);

[RaisesException] void convertToSpecifiedUnits(unsigned short unitType);

« no previous file with comments | « LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt ('k') | Source/core/svg/SVGLength.idl » ('j') | Source/core/svg/SVGLength.idl » ('J')