Remove obsolete %CallSuperWithSpread intrinsic.

Remove obsolete %CallSuperWithSpread intrinsic.

The aforementioned intrinsic is no longer needed and can be fully
desugared now that binding assignments to 'this' are explicit.

R=rossberg@chromium.org

Committed: https://crrev.com/0dcba070a974f23f7ff822e61816a3e2f8fa75ef
Cr-Commit-Position: refs/heads/master@{#29706}

[Michael Starzinger, 2015-07-16 11:42:15]

mstarzinger@chromium.org changed reviewers:
+ adamk@chromium.org, caitpotter88@gmail.com

[Michael Starzinger, 2015-07-16 11:42:15]

Andreas: PTAL.
Adam, Caitlin: FYI.

[caitp (gmail), 2015-07-16 11:47:19]

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args->InsertAt(0, get_prototype, zone());
Don't you need to also initialize `this` after the call?

[rossberg, 2015-07-16 11:59:35]

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args->InsertAt(0, get_prototype, zone());
On 2015/07/16 11:47:19, caitp wrote:
> Don't you need to also initialize `this` after the call?

Indeed, it seems like we have zero test coverage for checking the return value
of super calls, with spread or without.

[caitp (gmail), 2015-07-16 12:08:15]

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args->InsertAt(0, get_prototype, zone());
On 2015/07/16 11:59:34, rossberg wrote:
> On 2015/07/16 11:47:19, caitp wrote:
> > Don't you need to also initialize `this` after the call?
> 
> Indeed, it seems like we have zero test coverage for checking the return value
> of super calls, with spread or without.

Looks like https://crrev.com/1226123010 handles the `this` initialization, just
could not see it in this one.

There is definitely some code coverage for this in
harmony/spread-call-new-classes and a few other places, which would fail without
the initialization

[rossberg, 2015-07-16 12:11:23]

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args->InsertAt(0, get_prototype, zone());
On 2015/07/16 12:08:14, caitp wrote:
> There is definitely some code coverage for this in
> harmony/spread-call-new-classes and a few other places, which would fail
without
> the initialization

I was looking at the generic super.js test, which never checks anywhere (but
should).

[rossberg, 2015-07-16 12:11:48]

LGTM

[Michael Starzinger, 2015-07-16 12:11:48]

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args->InsertAt(0, get_prototype, zone());
On 2015/07/16 11:47:19, caitp wrote:
> Don't you need to also initialize `this` after the call?

This is done by the CL that is based on. Sorry, I should have mentioned that in
the message. I realize now that it's not obvious. Here is the piece that adds
the initialization:

https://codereview.chromium.org/1226123010/diff/20001/src/preparser.h#new-lin...

[Michael Starzinger, 2015-07-16 14:58:44]

Ported to all architectures. Landing.

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args->InsertAt(0, get_prototype, zone());
On 2015/07/16 12:11:23, rossberg wrote:
> On 2015/07/16 12:08:14, caitp wrote:
> > There is definitely some code coverage for this in
> > harmony/spread-call-new-classes and a few other places, which would fail
> without
> > the initialization
> 
> I was looking at the generic super.js test, which never checks anywhere (but
> should).

Done. I added test coverage in another CL already.

[Michael Starzinger, 2015-07-16 15:05:19]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-07-16 15:05:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1234383002/#ps40001
(title: "Ported to all architectures.")

[commit-bot: I haz the power, 2015-07-16 15:05:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234383002/40001

[commit-bot: I haz the power, 2015-07-16 15:07:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-16 15:08:13]

Patchset 3 (id:??) landed as
https://crrev.com/0dcba070a974f23f7ff822e61816a3e2f8fa75ef
Cr-Commit-Position: refs/heads/master@{#29706}