Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1234343005: Re-land "Update docs and command line flags for MB." (Closed)

Created:
5 years, 5 months ago by Dirk Pranke
Modified:
5 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Update docs and command line flags for MB." This patch re-lands {#338951} https://crrev.com/747cb269970294b7928ca30a3cde192c90072d13 with the necessary fix (a missing command-line arg). TBR=maruel@chromium.org Committed: https://crrev.com/a5a77ca71d9b52c00092e3a96d3b8048aa5d7515 Cr-Commit-Position: refs/heads/master@{#339164}

Patch Set 1 : original patch #

Patch Set 2 : add missing command line argument #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -32 lines) Patch
M tools/mb/README.md View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/mb/docs/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/mb/docs/design_spec.md View 4 chunks +6 lines, -3 lines 0 comments Download
M tools/mb/docs/user_guide.md View 5 chunks +74 lines, -24 lines 0 comments Download
M tools/mb/mb.py View 1 2 chunks +9 lines, -3 lines 3 comments Download

Messages

Total messages: 12 (3 generated)
Dirk Pranke
not sure how that flag got deleted, probably was a bad merge.
5 years, 5 months ago (2015-07-16 21:41:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234343005/20001
5 years, 5 months ago (2015-07-16 21:42:18 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/88351)
5 years, 5 months ago (2015-07-16 22:24:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234343005/20001
5 years, 5 months ago (2015-07-16 22:35:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-16 23:24:24 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a5a77ca71d9b52c00092e3a96d3b8048aa5d7515 Cr-Commit-Position: refs/heads/master@{#339164}
5 years, 5 months ago (2015-07-16 23:25:36 UTC) #9
M-A Ruel
lgtm https://codereview.chromium.org/1234343005/diff/20001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/1234343005/diff/20001/tools/mb/mb.py#newcode114 tools/mb/mb.py:114: '(default is //tools/mb/mb_config.pyl)') default is %default ?
5 years, 5 months ago (2015-07-17 01:17:13 UTC) #10
Dirk Pranke
https://codereview.chromium.org/1234343005/diff/20001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/1234343005/diff/20001/tools/mb/mb.py#newcode114 tools/mb/mb.py:114: '(default is //tools/mb/mb_config.pyl)') On 2015/07/17 01:17:13, M-A Ruel wrote: ...
5 years, 5 months ago (2015-07-17 01:22:48 UTC) #11
M-A Ruel
5 years, 5 months ago (2015-07-17 01:25:28 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/1234343005/diff/20001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/1234343005/diff/20001/tools/mb/mb.py#newcode114
tools/mb/mb.py:114: '(default is //tools/mb/mb_config.pyl)')
On 2015/07/17 01:22:48, Dirk Pranke wrote:
> On 2015/07/17 01:17:13, M-A Ruel wrote:
> > default is %default
> > ?
> 
> We don't want that because the actual default is an absolute path, not a
> src-relative path.

ok!

Powered by Google App Engine
This is Rietveld 408576698