Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1234343003: Revert of Update docs and command line flags for MB. (Closed)

Created:
5 years, 5 months ago by tsergeant
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@rm_gnisolate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update docs and command line flags for MB. (patchset #3 id:40001 of https://codereview.chromium.org/1206633003/) Reason for revert: This CL appears to be causing tryjobs to fail. See: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/110208/steps/analyze/logs/stdio and https://crbug.com/510655 Original issue's description: > Update docs and command line flags for MB. > > This adds the information about how the integration w/ isolates works, > and does a bunch of additional cleanup to make sure everything is > documented and in sync. > > R=maruel@chromium.org > BUG= > > Committed: https://crrev.com/747cb269970294b7928ca30a3cde192c90072d13 > Cr-Commit-Position: refs/heads/master@{#338951} TBR=maruel@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f061c99013c416af0eeb06a2d898e03a4bdc722e Cr-Commit-Position: refs/heads/master@{#338967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -95 lines) Patch
M tools/mb/README.md View 1 chunk +2 lines, -2 lines 0 comments Download
D tools/mb/docs/README.md View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/mb/docs/design_spec.md View 4 chunks +3 lines, -6 lines 0 comments Download
M tools/mb/docs/user_guide.md View 5 chunks +24 lines, -74 lines 0 comments Download
M tools/mb/mb.py View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tsergeant
Created Revert of Update docs and command line flags for MB.
5 years, 5 months ago (2015-07-16 01:32:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234343003/1
5 years, 5 months ago (2015-07-16 01:32:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 01:34:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f061c99013c416af0eeb06a2d898e03a4bdc722e Cr-Commit-Position: refs/heads/master@{#338967}
5 years, 5 months ago (2015-07-16 01:35:20 UTC) #4
Dirk Pranke
5 years, 5 months ago (2015-07-16 03:25:35 UTC) #5
Message was sent while issue was closed.
On 2015/07/16 01:35:20, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/f061c99013c416af0eeb06a2d898e03a4bdc722e
> Cr-Commit-Position: refs/heads/master@{#338967}

lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698