Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1234313006: Stop running image tests on msaa. (Closed)

Created:
5 years, 5 months ago by scroggo_chromium
Modified:
5 years, 5 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop running image tests on msaa. Blacklist all image tests on msaa. We do not run them anyway (since they will not do anything interestingly different from drawing to the raster backend) - we early exit from Src::draw(), but we still need to create a render target that matches the size of the image (when not blacklisted). Remove the more specific blacklist of a particular image, which is covered by this one. BUG=skia:4045 Committed: https://skia.googlesource.com/skia/+/c1121efbc6addc8262b88e8f08ad5a4653fbea62

Patch Set 1 #

Patch Set 2 : Just testing presubmit hooks #

Patch Set 3 : add dm_flags.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M tools/dm_flags.json View 1 2 10 chunks +30 lines, -30 lines 0 comments Download
M tools/dm_flags.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
scroggo
FYI: I got the following message from presubmit, which is unrelated to my CL: Traceback ...
5 years, 5 months ago (2015-07-16 17:24:13 UTC) #2
mtklein
On 2015/07/16 17:24:13, scroggo wrote: > FYI: I got the following message from presubmit, which ...
5 years, 5 months ago (2015-07-16 19:17:18 UTC) #3
mtklein
On 2015/07/16 19:17:18, mtklein wrote: > On 2015/07/16 17:24:13, scroggo wrote: > > FYI: I ...
5 years, 5 months ago (2015-07-16 19:18:43 UTC) #4
scroggo
On 2015/07/16 19:18:43, mtklein wrote: > On 2015/07/16 19:17:18, mtklein wrote: > > On 2015/07/16 ...
5 years, 5 months ago (2015-07-16 19:21:23 UTC) #5
mtklein
On 2015/07/16 19:21:23, scroggo wrote: > On 2015/07/16 19:18:43, mtklein wrote: > > On 2015/07/16 ...
5 years, 5 months ago (2015-07-16 19:22:40 UTC) #6
mtklein
On 2015/07/16 19:21:23, scroggo wrote: > On 2015/07/16 19:18:43, mtklein wrote: > > On 2015/07/16 ...
5 years, 5 months ago (2015-07-16 19:22:40 UTC) #7
scroggo
On 2015/07/16 19:22:40, mtklein wrote: > On 2015/07/16 19:21:23, scroggo wrote: > > On 2015/07/16 ...
5 years, 5 months ago (2015-07-16 19:26:26 UTC) #8
mtklein
lgtm
5 years, 5 months ago (2015-07-16 19:28:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234313006/40001
5 years, 5 months ago (2015-07-16 19:28:37 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 19:36:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c1121efbc6addc8262b88e8f08ad5a4653fbea62

Powered by Google App Engine
This is Rietveld 408576698