build/common.gypi - Issue 1234253003: Disable VS 2015 warning that fires on compiler-generated constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1234253003: Disable VS 2015 warning that fires on compiler-generated constructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added to .gn configuration and sorted. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 67eb8ac5f4ca3aa3aad94d42338d367eaae03954..b119e7b23872076cfc33a0e2ee9abe13d9ad6e69 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -5611,6 +5611,12 @@

# trying to prevent it.

4503,

+ # Warning C4589 says: "Constructor of abstract class ignores

+ # initializer for virtual base class." Disable this warning because it

+ # is flaky in VS 2015 RTM. It triggers on compiler generated

+ # copy-constructors in some cases.

+ 4589,

# C4611: interaction between 'function' and C++ object destruction is

# non-portable

# This warning is unavoidable when using e.g. setjmp/longjmp. MSDN

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »