sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart - Issue 123423002: Fix checkedInstructionOrNonGenerateAtUseSite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

Issue 123423002: Fix checkedInstructionOrNonGenerateAtUseSite. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

index 2caf6410e93999ea6cf039426b1dda21cbc461fa..97628a04c0a5b4a0a03e17db2baa7f914345f9bc 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

@@ -116,11 +116,7 @@ class SsaInstructionSelection extends HBaseVisitor {

HInstruction interceptor = node.inputs[0];

HInstruction receiverArgument = node.inputs[1];

- // TODO(15720): The test here should be

- //

- // interceptor.nonCheck() == receiverArgument.nonCheck()

- //

- if (interceptor == receiverArgument) {

+ if (interceptor.nonCheck() == receiverArgument.nonCheck()) {

// TODO(15933): Make automatically generated property extraction

// closures work with the dummy receiver optimization.

if (!selector.isGetter()) {

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart » ('j') | no next file with comments »