Fix checkedInstructionOrNonGenerateAtUseSite.

sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 /**
  * This phase simplifies interceptors in multiple ways:
  *
  * 1) If the interceptor is for an object whose type is known, it
@@ skipping 238 matching lines @@
     interceptor.sourceElement = user.sourceElement;
 
     HBasicBlock block = user.block;
     block.addAfter(user, interceptor);
     block.rewrite(user, interceptor);
     block.remove(user);
     return true;
   }
 
   bool rewriteToUseSelfAsInterceptor(HInterceptor node, HInstruction receiver) {
-    node.block.rewrite(node, receiver);
+    for (HInstruction user in node.usedBy.toList()) {
+      if (user is HIs) {
+        user.changeUse(node, receiver);
+      } else {
+        // Use the potentially self-argument as new receiver. Note that the
+        // self-argument could potentially have a tighter type than the
+        // receiver which was the input to the interceptor.

[sra1, 2014/05/08 03:34:35]

Please add a test/guard against 'use' being an argument rather than the
receiver.  It would be relatively simple to change the calls to getInterceptor
in the runtime library to an intrinsic that generates HInterceptor and maybe
benefit from GVN.

[floitsch, 2014/05/08 18:21:56]

Done.

+        user.changeUse(node, user.inputs[1]);
+      }
+    }
     return false;
   }
 
   bool visitOneShotInterceptor(HOneShotInterceptor node) {
     HInstruction constant = tryComputeConstantInterceptor(
         node.inputs[1], node.interceptedClasses);
 
     if (constant == null) return false;
 
     Selector selector = node.selector;
@@ skipping 16 matching lines @@
       instruction = new HInvokeDynamicMethod(
           selector, inputs, node.instructionType, true);
     }
 
     HBasicBlock block = node.block;
     block.addAfter(node, instruction);
     block.rewrite(node, instruction);
     return true;
   }
 }