chrome/browser/ui/libgtk2ui/owned_widget_gtk2.cc - Issue 1234223005: Initial gtk3 support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/libgtk2ui/owned_widget_gtk2.cc

Issue 1234223005: Initial gtk3 support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Silence gtk memory leak Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/libgtk2ui/owned_widget_gtk2.cc

diff --git a/chrome/browser/ui/libgtk2ui/owned_widget_gtk2.cc b/chrome/browser/ui/libgtk2ui/owned_widget_gtk2.cc

index cf6a3a4283a3d8ae760829f4257da1106ab646e2..e45996895a964295717706a92c62233c5bca8376 100644

--- a/chrome/browser/ui/libgtk2ui/owned_widget_gtk2.cc

+++ b/chrome/browser/ui/libgtk2ui/owned_widget_gtk2.cc

@@ -19,11 +19,8 @@ void OwnedWidgetGtk::Own(GtkWidget* widget) {

return;

DCHECK(!widget_);

- // We want to make sure that Own() was called properly, right after the

- // widget was created. There should be a floating reference.

- DCHECK(g_object_is_floating(widget));

- // Sink the floating reference, we should now own this reference.

+ // Keep a reference

g_object_ref_sink(widget);

widget_ = widget;

}