Initial gtk3 support

chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc

Index: chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc
diff --git a/chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc b/chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc
index 3ade5923dbc8165c0eb8ab9aaa87a8d9196b545e..1a5c0a7d574294fefaa203e244e892e4da02a102 100644
--- a/chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc
+++ b/chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc
@@ -488,6 +488,13 @@ void PrintDialogGtk2::OnResponse(GtkWidget* dialog, int response_id) {
   }
 }
 
+
+
+static void OnJobCompletedThunk(GtkPrintJob* print_job,
+                                gpointer user_data,
+                                const GError* error) {
+  static_cast<PrintDialogGtk2*>(user_data)->OnJobCompleted(print_job, error);
+}

[Elliot Glaysher, 2015/07/20 19:31:40]

Why was the thunk moved here? If you left it as a static member you wouldn't
have to move this.

[knthzh, 2015/07/21 15:48:27]

I think I just wanted to remove it from the public header interface. Should I
put it back?

 void PrintDialogGtk2::SendDocumentToPrinter(
     const base::string16& document_name) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -512,14 +519,7 @@ void PrintDialogGtk2::SendDocumentToPrinter(
   gtk_print_job_send(print_job, OnJobCompletedThunk, this, NULL);
 }
 
-// static
-void PrintDialogGtk2::OnJobCompletedThunk(GtkPrintJob* print_job,
-                                         gpointer user_data,
-                                         GError* error) {
-  static_cast<PrintDialogGtk2*>(user_data)->OnJobCompleted(print_job, error);
-}
-
-void PrintDialogGtk2::OnJobCompleted(GtkPrintJob* print_job, GError* error) {
+void PrintDialogGtk2::OnJobCompleted(GtkPrintJob* print_job, const GError* error) {
   if (error)
     LOG(ERROR) << "Printing failed: " << error->message;
   if (print_job)