Initial gtk3 support

content/browser/browser_main_loop.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_main_loop.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/logging.h"
@@ skipping 216 matching lines @@
     LOG(ERROR) << "DConf settings backend could not connect to session bus: "
                << "http://crbug.com/179797";
   } else if (strstr(message, "Attempting to store changes into") ||
              strstr(message, "Attempting to set the permissions of")) {
     LOG(ERROR) << message << " (http://bugs.chromium.org/161366)";
   } else if (strstr(message, "drawable is not a native X11 window")) {
     LOG(ERROR) << message << " (http://bugs.chromium.org/329991)";
   } else if (strstr(message, "Cannot do system-bus activation with no user")) {
     LOG(ERROR) << message << " (http://crbug.com/431005)";
   } else {
-    LOG(DFATAL) << log_domain << ": " << message;
+    LOG(ERROR) << log_domain << ": " << message;

[Elliot Glaysher, 2015/07/20 19:31:40]

What messages were added here which tripped the DFATAL?

[knthzh, 2015/07/21 15:48:27]

Whoops, didn't know git-cl doesn't preserve commit messages.

So, GtkPrintUnixDialog hasn't been ported properly to gtk3. It still uses the
deprecated property GtkButton:xalign, which means that calling
gtk_print_unix_dialog_new triggers a warning message, which results in those
crashes/aborts that I mentioned earlier.

I could strstr for "deprecated", but I don't know if cherry picking specific
non-fatal warning messages is a good idea. It just feels too much like an
unexpected gtk3 upgrade could cause completely avoidable aborts.

   }
 }
 
 static void SetUpGLibLogHandler() {
   // Register GLib-handled assertions to go through our logging system.
   const char* kLogDomains[] = { NULL, "Gtk", "Gdk", "GLib", "GLib-GObject" };
   for (size_t i = 0; i < arraysize(kLogDomains); i++) {
     g_log_set_handler(kLogDomains[i],
                       static_cast<GLogLevelFlags>(G_LOG_FLAG_RECURSION |
                                                   G_LOG_FLAG_FATAL |
@@ skipping 1098 matching lines @@
   DCHECK(is_tracing_startup_);
 
   is_tracing_startup_ = false;
   TracingController::GetInstance()->DisableRecording(
       TracingController::CreateFileSink(
           startup_trace_file_,
           base::Bind(OnStoppedStartupTracing, startup_trace_file_)));
 }
 
 }  // namespace content