Issue 12342030: Revert 184868

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12342030: Revert 184868 (Closed)

Created:
7 years, 10 months ago by Mark P

Modified:
7 years, 10 months ago

Reviewers:
erikwright (departed)

CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org, erikwright+watch_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 184868 Seems to cause timeout in MultiThreadedCookieMonsterTest.ThreadCheckDeleteCanonicalCookie http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%281%29/builds/6970 I often chalk timeouts up to flakes and reopen the tree and wait but this failure (threading + cookies) seems to directly relevant to this changelist I'm just going ahead to revert. > Make SQLitePersistentCookieStore run on injected SequencedTaskRunners vs named BrowserThreads. > > In a follow-up, I will make the production code run on the worker pool, which will hopefully speed up browser startup by eliminating delays due to other long-running DB thread tasks. > > R=rdsmith@chromium.org > TBR=jar@chromium.org,mmenke@chromium.org > BUG=175415 > > > Review URL: https://chromiumcodereview.appspot.com/12314015 TBR=erikwright@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184874

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+203 lines, -235 lines)			Patch
M	base/base.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/net/sqlite_persistent_cookie_store.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/net/sqlite_persistent_cookie_store.cc	View	28 chunks	+108 lines, -130 lines	0 comments	Download
M	chrome/browser/net/sqlite_persistent_cookie_store_perftest.cc	View	3 chunks	+18 lines, -33 lines	0 comments	Download
M	chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc	View	8 chunks	+73 lines, -48 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl_io_data.cc	View	3 chunks	+1 line, -10 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r184874.

Expand Messages | Collapse Messages