Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 12342028: make menus, bubbles, etc. top level windows on aura (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fixes Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_aura.cc
diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc
index cdc7ce87c03bf331be84483405c04c74015be56b..932ac9d0815009fbf8dc141bcd4427fedb1ef248 100644
--- a/content/browser/web_contents/web_contents_view_aura.cc
+++ b/content/browser/web_contents/web_contents_view_aura.cc
@@ -147,6 +147,9 @@ class OverscrollWindowDelegate : public aura::WindowDelegate {
return gfx::Size();
}
+ virtual void SetHostTransitionBounds(const gfx::Rect& bounds) OVERRIDE {
+ }
+
virtual void OnBoundsChanged(const gfx::Rect& old_bounds,
const gfx::Rect& new_bounds) OVERRIDE {
}
@@ -212,6 +215,9 @@ class OverscrollWindowDelegate : public aura::WindowDelegate {
delete this;
}
+ virtual void OnWindowHidingAnimationCompleted() OVERRIDE {
+ }
+
virtual void OnWindowTargetVisibilityChanged(bool visible) OVERRIDE {
}
@@ -1480,6 +1486,9 @@ gfx::Size WebContentsViewAura::GetMaximumSize() const {
return gfx::Size();
}
+void WebContentsViewAura::SetHostTransitionBounds(const gfx::Rect& bounds) {
+}
+
void WebContentsViewAura::OnBoundsChanged(const gfx::Rect& old_bounds,
const gfx::Rect& new_bounds) {
SizeChangedCommon(new_bounds.size());
@@ -1542,6 +1551,9 @@ void WebContentsViewAura::OnWindowDestroying() {
void WebContentsViewAura::OnWindowDestroyed() {
}
+void WebContentsViewAura::OnWindowHidingAnimationCompleted() {
+}
+
void WebContentsViewAura::OnWindowTargetVisibilityChanged(bool visible) {
if (visible)
web_contents_->WasShown();

Powered by Google App Engine
This is Rietveld 408576698