Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: sdk/lib/async/timer.dart

Issue 12342014: Remove deprecated ms arguments for Timer and Future. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/async/timer.dart
diff --git a/sdk/lib/async/timer.dart b/sdk/lib/async/timer.dart
index 39fe4c2df6202e1500940372e47d2583085f16b8..76108c30f17ab885ddc04c8ec73412cfb7ccad00 100644
--- a/sdk/lib/async/timer.dart
+++ b/sdk/lib/async/timer.dart
@@ -8,9 +8,8 @@ abstract class Timer {
/**
* Creates a new timer.
*
- * The [callback] callback is invoked after the given [duration]
- * (a [Duration]) has passed. A negative duration is treated similar to
- * a duration of 0.
+ * The [callback] callback is invoked after the given [duration].
+ * A negative duration is treated similar to a duration of 0.
*
* If the [duration] is statically known to be 0, consider using [run].
*
@@ -25,24 +24,16 @@ abstract class Timer {
* var duration = milliseconds == null ? TIMEOUT : ms * milliseconds;
* return new Timer(duration, handleTimeout);
* }
- *
- * *Deprecation warning*: this constructor used to take an [int] (the time
- * in milliseconds) and a callback with one argument (the timer). This has
- * changed to a [Duration] and a callback without arguments.
*/
- // TODO(floitsch): add types.
- external factory Timer(var duration, Function callback);
+ external factory Timer(Duration duration, void callback());
/**
* Creates a new repeating timer.
*
* The [callback] is invoked repeatedly with [duration] intervals until
* canceled. A negative duration is treated similar to a duration of 0.
- *
- * *Deprecation warning*: this constructor used to take an [int] (the time
- * in milliseconds). This has changed to a [Duration].
*/
- external factory Timer.repeating(var duration,
+ external factory Timer.repeating(Duration duration,
void callback(Timer timer));
/**
@@ -52,7 +43,7 @@ abstract class Timer {
* anymore.
*/
static Timer run(void callback()) {
- return new Timer(const Duration(), callback);
+ return new Timer(const Duration(milliseconds: 0), callback);
}
/**

Powered by Google App Engine
This is Rietveld 408576698