Use InternalArray in Object.getOwnPropertyNames() implementation

src/array.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1531 matching lines @@
     "every", getFunction("every", ArrayEvery, 1),
     "map", getFunction("map", ArrayMap, 1),
     "indexOf", getFunction("indexOf", ArrayIndexOf, 1),
     "lastIndexOf", getFunction("lastIndexOf", ArrayLastIndexOf, 1),
     "reduce", getFunction("reduce", ArrayReduce, 1),
     "reduceRight", getFunction("reduceRight", ArrayReduceRight, 1)
   ));
 
   %FinishArrayPrototypeSetup($Array.prototype);
 
+  // Make InternalArray.prototype.concat return an InternalArray
+  // instead of an Array.
+  var getInternalArrayConcat = function(concatFn) {

[Michael Starzinger, 2013/03/12 12:09:06]

Drop this wrapper generator for a wrapper function.

[adamk, 2013/03/12 18:25:19]

Done.

+    return function() {
+      var result = %Apply(concatFn, this, arguments, 0, %_ArgumentsLength());
+      var internalResult = new InternalArray();
+      %MoveArrayContents(result, internalResult);
+      return internalResult;
+    };
+  };
+
   // The internal Array prototype doesn't need to be fancy, since it's never
   // exposed to user code.
   // Adding only the functions that are actually used.
   SetUpLockedPrototype(InternalArray, $Array(), $Array(
+    "concat", getInternalArrayConcat(getFunction("concat", ArrayConcat)),

[Michael Starzinger, 2013/03/12 12:09:06]

Just install the plain unwrapped ArrayConcat functionality here.

[adamk, 2013/03/12 18:25:19]

Done.

     "indexOf", getFunction("indexOf", ArrayIndexOf),
     "join", getFunction("join", ArrayJoin),
     "pop", getFunction("pop", ArrayPop),
     "push", getFunction("push", ArrayPush),
     "splice", getFunction("splice", ArraySplice)
   ));
 
   SetUpLockedPrototype(InternalPackedArray, $Array(), $Array(
     "join", getFunction("join", ArrayJoin),
     "pop", getFunction("pop", ArrayPop),
     "push", getFunction("push", ArrayPush)
   ));
 }
 
 SetUpArray();