content/renderer/render_view_browsertest.cc - Issue 1234193002: Simplify InputMethodWin initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1234193002: Simplify InputMethodWin initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index a1d362d4c7bab21be70679b83a985373395505eb..330d83337f5bd3a2ba36f5b7e2dbfab94e9d7e2a 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -911,9 +911,6 @@ TEST_F(RenderViewImplTest, DISABLED_LastCommittedUpdateState) {

// Test that our IME backend sends a notification message when the input focus

// changes.

TEST_F(RenderViewImplTest, OnImeTypeChanged) {

- // Enable our IME backend code.

- view()->OnSetInputMethodActive(true);

// Load an HTML page consisting of two input fields.

view()->set_send_content_state_immediately(true);

LoadHTML("<html>"

@@ -1103,7 +1100,6 @@ TEST_F(RenderViewImplTest, ImeComposition) {

// Load an HTML page consisting of a content-editable <div> element,

// and move the input focus to the <div> element, where we can use

// IMEs.

- view()->OnSetInputMethodActive(ime_message->enable);

view()->set_send_content_state_immediately(true);

LoadHTML("<html>"

"<head>"

@@ -1116,8 +1112,6 @@ TEST_F(RenderViewImplTest, ImeComposition) {

break;

case IME_SETINPUTMODE:

- // Activate (or deactivate) our IME back-end.

- view()->OnSetInputMethodActive(ime_message->enable);

break;

case IME_SETFOCUS:

@@ -1750,7 +1744,6 @@ TEST_F(RenderViewImplTest, GetCompositionCharacterBoundsTest) {

const std::vector<blink::WebCompositionUnderline> empty_underline;

std::vector<gfx::Rect> bounds;

view()->OnSetFocus(true);

- view()->OnSetInputMethodActive(true);

// ASCII composition

const base::string16 ascii_composition = base::UTF8ToUTF16("aiueo");

@@ -1941,7 +1934,6 @@ TEST_F(RenderViewImplTest, GetSSLStatusOfFrame) {

}

TEST_F(RenderViewImplTest, MessageOrderInDidChangeSelection) {

- view()->OnSetInputMethodActive(true);

view()->set_send_content_state_immediately(true);

LoadHTML("<textarea id=\"test\"></textarea>");

« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_widget.h » ('j') | content/renderer/render_widget.cc » ('J')