Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 1234193002: Simplify InputMethodWin initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index ae83db38f62abf8ef4ba125e3234b4061afaa97a..853d66993d677d8af9e1cc9094ab094381cdb1c0 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -1750,9 +1750,6 @@ void RenderWidgetHostViewAura::OnInputMethodChanged() {
if (!host_)
return;
- if (GetInputMethod())
- host_->SetInputMethodActive(GetInputMethod()->IsActive());
-
// TODO(suzhe): implement the newly added “locale” property of HTML DOM
// TextEvent.
}
@@ -2302,14 +2299,11 @@ void RenderWidgetHostViewAura::OnWindowFocused(aura::Window* gained_focus,
// Ask the system-wide IME to send all TextInputClient messages to |this|
// object.
input_method->SetFocusedTextInputClient(this);
- host_->SetInputMethodActive(input_method->IsActive());
// Often the application can set focus to the view in response to a key
// down. However the following char event shouldn't be sent to the web
// page.
host_->SuppressNextCharEvents();
- } else {
- host_->SetInputMethodActive(false);
}
BrowserAccessibilityManager* manager =
@@ -2321,7 +2315,6 @@ void RenderWidgetHostViewAura::OnWindowFocused(aura::Window* gained_focus,
host_->Blur();
DetachFromInputMethod();
- host_->SetInputMethodActive(false);
if (touch_editing_client_)
touch_editing_client_->EndTouchEditing(false);

Powered by Google App Engine
This is Rietveld 408576698