Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 1234153003: Reland of Fix slow repaint object registration (Closed)

Created:
5 years, 5 months ago by Noel Gordon
Modified:
5 years, 5 months ago
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland of Fix slow repaint object registration (patchset #1 id:1 of https://codereview.chromium.org/1224083019/) Reason for revert: This patch was not the cause, relanding. Original issue's description: > Revert of Fix slow repaint object registration (patchset #2 id:20001 of https://codereview.chromium.org/1240443003/) > > Reason for revert: > Speculative revert: appears to have broken Linux MSAN bots. > > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/4413 > > > Original issue's description: > > Fix slow repaint object registration > > > > The LayoutView now paints background, so the special condition to accelerate > > frame scrolling with fixed root background should be updated as well. > > > > As a drive-by fix, this CL also corrects slow repaint object accounting so > > we no longer leak slow repaint object count. > > > > BUG=506002 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198894 > > TBR=vollick@chromium.org,trchen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=506002 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198913 TBR=vollick@chromium.org,trchen@chromium.org,rtoy@chromium.org,yosin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -36 lines) Patch
M Source/core/layout/LayoutBox.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 4 chunks +15 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Noel Gordon
Created Reland of Fix slow repaint object registration
5 years, 5 months ago (2015-07-15 04:22:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234153003/1
5 years, 5 months ago (2015-07-15 04:23:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198920
5 years, 5 months ago (2015-07-15 04:23:55 UTC) #3
trchen
Really? The MSAN bots failure message looks exactly due to my patch, and I did ...
5 years, 5 months ago (2015-07-15 06:16:16 UTC) #4
Noel Gordon
On 2015/07/15 06:16:16, trchen wrote: > Really? The MSAN bots failure message looks exactly due ...
5 years, 5 months ago (2015-07-15 07:09:35 UTC) #5
Noel Gordon
On 2015/07/15 07:09:35, noel gordon wrote: > and still waiting for the bot to go ...
5 years, 5 months ago (2015-07-15 07:23:29 UTC) #6
Noel Gordon
Ah well, reverting is the safer option.
5 years, 5 months ago (2015-07-15 08:34:27 UTC) #7
Noel Gordon
5 years, 5 months ago (2015-07-15 08:35:44 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1234183003/ by noel@chromium.org.

The reason for reverting is: Speculative revert: appears to have broken Linux
MSAN bots. Author suggested there was in uninited varible use in their code..

Powered by Google App Engine
This is Rietveld 408576698