Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Issue 1234123004: Match works correctly on visualbench (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Match works correctly on visualbench BUG=skia: Committed: https://skia.googlesource.com/skia/+/82874f8b28f2d04bf5a88f4203ca087b2b8684ce

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/VisualBench/VisualBenchmarkStream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-15 15:21:13 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/1234123004/diff/1/tools/VisualBench/VisualBenchmarkStream.cpp File tools/VisualBench/VisualBenchmarkStream.cpp (right): https://codereview.chromium.org/1234123004/diff/1/tools/VisualBench/VisualBenchmarkStream.cpp#newcode68 tools/VisualBench/VisualBenchmarkStream.cpp:68: Benchmark* bench; // skip non-matching benchs ...
5 years, 5 months ago (2015-07-15 15:25:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234123004/20001
5 years, 5 months ago (2015-07-15 15:30:31 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 15:38:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/82874f8b28f2d04bf5a88f4203ca087b2b8684ce

Powered by Google App Engine
This is Rietveld 408576698