Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1234083004: Remove the build_ffmpegsumo build variable. (Closed)

Created:
5 years, 5 months ago by watk
Modified:
5 years, 5 months ago
Reviewers:
Nico, DaleCurtis
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the build_ffmpegsumo build variable. build_ffmpegsumo no longer serves a purpose, e.g., it's not possible to build with media_use_ffmpeg=1 and build_ffmpegsumo=0. This rolls third_party/ffmpeg to pick up the new build files with build_ffmpegsumo removed. Committed: https://crrev.com/701cd4b29d05cf564d91ef2a4c536823f691ee73 Cr-Commit-Position: refs/heads/master@{#339320}

Patch Set 1 #

Patch Set 2 : another commit #

Patch Set 3 : Update deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
watk
Hi jam@, PTAL at common.gypi
5 years, 5 months ago (2015-07-17 17:20:13 UTC) #3
DaleCurtis
lgtm
5 years, 5 months ago (2015-07-17 18:10:52 UTC) #4
DaleCurtis
-jam, +thakis (build/OWNER)
5 years, 5 months ago (2015-07-17 18:13:29 UTC) #6
Nico
lgtm
5 years, 5 months ago (2015-07-17 20:16:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234083004/40001
5 years, 5 months ago (2015-07-17 20:20:15 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-17 20:37:41 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 20:38:36 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/701cd4b29d05cf564d91ef2a4c536823f691ee73
Cr-Commit-Position: refs/heads/master@{#339320}

Powered by Google App Engine
This is Rietveld 408576698