Source/platform/graphics/ImageBuffer.h - Issue 1234083003: Canvas.toDataURL to use SkBitmap::readPixels to avoid uninitialized memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/ImageBuffer.h

Issue 1234083003: Canvas.toDataURL to use SkBitmap::readPixels to avoid uninitialized memory (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: batter asan fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/HTMLCanvasElement.cpp ('k') | Source/platform/graphics/ImageBuffer.cpp » ('j') | Source/platform/image-encoders/skia/WEBPImageEncoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/ImageBuffer.h

diff --git a/Source/platform/graphics/ImageBuffer.h b/Source/platform/graphics/ImageBuffer.h

index 5009f52bb64f9ffa8434661b97f58234b864ce44..b018d1acb96c4601d3d6c2da200f1d29bf6d6264 100644

--- a/Source/platform/graphics/ImageBuffer.h

+++ b/Source/platform/graphics/ImageBuffer.h

@@ -124,7 +124,6 @@ public:

void putByteArray(Multiply, const unsigned char* source, const IntSize& sourceSize, const IntRect& sourceRect, const IntPoint& destPoint);

- String toDataURL(const String& mimeType, const double* quality = 0) const;

AffineTransform baseTransform() const { return AffineTransform(); }

WebLayer* platformLayer() const;