Source/core/html/HTMLCanvasElement.h - Issue 1234083003: Canvas.toDataURL to use SkBitmap::readPixels to avoid uninitialized memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCanvasElement.h

Issue 1234083003: Canvas.toDataURL to use SkBitmap::readPixels to avoid uninitialized memory (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: batter asan fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLCanvasElement.h

diff --git a/Source/core/html/HTMLCanvasElement.h b/Source/core/html/HTMLCanvasElement.h

index 1338d3d3cd09a0b6578ebc3f146544d6c7b89afc..73f6514589fe03833240ee50a0f0ccd0ee75c8ba 100644

--- a/Source/core/html/HTMLCanvasElement.h

+++ b/Source/core/html/HTMLCanvasElement.h

@@ -55,6 +55,7 @@ class HTMLCanvasElement;

class Image;

class ImageBuffer;

class ImageBufferSurface;

+class ImageData;

class IntSize;

class CORE_EXPORT CanvasObserver : public WillBeGarbageCollectedMixin {

@@ -199,6 +200,7 @@ private:

bool paintsIntoCanvasBuffer() const;

+ ImageData* toImageData(SourceDrawingBuffer) const;

String toDataURLInternal(const String& mimeType, const double* quality, SourceDrawingBuffer) const;

WillBeHeapHashSet<RawPtrWillBeWeakMember<CanvasObserver>> m_observers;

« no previous file with comments | « no previous file | Source/core/html/HTMLCanvasElement.cpp » ('j') | Source/platform/image-encoders/skia/WEBPImageEncoder.cpp » ('J')