Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1234073005: Simplify the Drawer animation (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
mpcomplete, Matt Perry
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Simplify the Drawer animation Instead of using AnimationBuilder, this CL has the Drawer just use the animations system directly. R=mpcomplete@chromium.org, mpcomplete@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c6d8cf07bc85a23ef6c1a33b1bf090c70a02ba10

Patch Set 1 #

Total comments: 3

Patch Set 2 : Less code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M sky/sdk/lib/widgets/drawer.dart View 1 4 chunks +33 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-15 00:07:56 UTC) #1
Matt Perry
I'd be curious to see what Material looks like under this model. https://codereview.chromium.org/1234073005/diff/1/sky/sdk/lib/widgets/animated.dart File sky/sdk/lib/widgets/animated.dart ...
5 years, 5 months ago (2015-07-15 00:20:18 UTC) #3
Matt Perry
LGTM
5 years, 5 months ago (2015-07-15 00:22:04 UTC) #4
abarth-chromium
https://codereview.chromium.org/1234073005/diff/1/sky/sdk/lib/widgets/animated.dart File sky/sdk/lib/widgets/animated.dart (right): https://codereview.chromium.org/1234073005/diff/1/sky/sdk/lib/widgets/animated.dart#newcode64 sky/sdk/lib/widgets/animated.dart:64: decoration: new BoxDecoration(backgroundColor: color.value), On 2015/07/15 at 00:20:18, Matt ...
5 years, 5 months ago (2015-07-15 00:23:53 UTC) #5
abarth-chromium
5 years, 5 months ago (2015-07-15 03:36:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c6d8cf07bc85a23ef6c1a33b1bf090c70a02ba10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698