Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1234073004: Chromecast: adds run_test_list.txt generation, internal tests for ATV. (Closed)

Created:
5 years, 5 months ago by gunsch
Modified:
5 years, 5 months ago
Reviewers:
lcwu1, halliwell
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds run_test_list.txt generation, internal tests for ATV. TBR=lcwu@chromium.org R=halliwell@chromium.org BUG=internal b/22465963 Committed: https://crrev.com/e4a7697c57127c9015972dfb7bc51e31e3291474 Cr-Commit-Position: refs/heads/master@{#338785}

Patch Set 1 #

Patch Set 2 : removes sandbox_linux_jni_unittests_apk from filters line #

Patch Set 3 : Adds cast_base_unittests and cast_crash_unittests #

Total comments: 2

Patch Set 4 : added bug for failing sandbox tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -44 lines) Patch
M chromecast/chromecast_tests.gypi View 1 2 3 6 chunks +110 lines, -44 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
gunsch
5 years, 5 months ago (2015-07-14 21:02:23 UTC) #1
gunsch
I think there's a case to be made here for fewer, larger unit test targets...
5 years, 5 months ago (2015-07-14 21:14:57 UTC) #2
halliwell
On 2015/07/14 21:14:57, gunsch wrote: > I think there's a case to be made here ...
5 years, 5 months ago (2015-07-14 21:52:11 UTC) #3
halliwell
https://codereview.chromium.org/1234073004/diff/40001/chromecast/chromecast_tests.gypi File chromecast/chromecast_tests.gypi (right): https://codereview.chromium.org/1234073004/diff/40001/chromecast/chromecast_tests.gypi#newcode235 chromecast/chromecast_tests.gypi:235: # Note(gunsch): crashes 100% on Fugu. do we have ...
5 years, 5 months ago (2015-07-14 21:52:19 UTC) #4
gunsch
https://codereview.chromium.org/1234073004/diff/40001/chromecast/chromecast_tests.gypi File chromecast/chromecast_tests.gypi (right): https://codereview.chromium.org/1234073004/diff/40001/chromecast/chromecast_tests.gypi#newcode235 chromecast/chromecast_tests.gypi:235: # Note(gunsch): crashes 100% on Fugu. On 2015/07/14 21:52:19, ...
5 years, 5 months ago (2015-07-14 23:34:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234073004/60001
5 years, 5 months ago (2015-07-14 23:34:47 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-14 23:34:50 UTC) #10
gunsch
+lcwu (committer stamp, sigh)
5 years, 5 months ago (2015-07-15 00:09:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234073004/60001
5 years, 5 months ago (2015-07-15 00:23:23 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-15 00:40:06 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e4a7697c57127c9015972dfb7bc51e31e3291474 Cr-Commit-Position: refs/heads/master@{#338785}
5 years, 5 months ago (2015-07-15 00:41:20 UTC) #16
lcwu1
5 years, 5 months ago (2015-07-15 00:45:01 UTC) #17
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698