Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/ssl_client_certificate_selector.cc

Issue 1234073002: Allow cert-popup for WebView guests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Inline Mac check for top-level web-contents. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/certificate_selector.cc ('K') | « chrome/browser/ui/views/certificate_selector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/ssl_client_certificate_selector.cc
diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector.cc b/chrome/browser/ui/views/ssl_client_certificate_selector.cc
index c76ab8e6a30cfabb96dd78cbdfc603c101d2b38b..1963b26447adc99a0216bc5923e50a56309794aa 100644
--- a/chrome/browser/ui/views/ssl_client_certificate_selector.cc
+++ b/chrome/browser/ui/views/ssl_client_certificate_selector.cc
@@ -105,7 +105,7 @@ void ShowSSLClientCertificateSelector(
//
// TODO(davidben): Move this hook to the WebContentsDelegate and only try to
// show a dialog in Browser's implementation. https://crbug.com/456255
- if (web_modal::PopupManager::FromWebContents(contents) == nullptr)
+ if (!SSLClientCertificateSelector::CanShow(contents))
return;
SSLClientCertificateSelector* selector = new SSLClientCertificateSelector(
« chrome/browser/ui/views/certificate_selector.cc ('K') | « chrome/browser/ui/views/certificate_selector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698