Issue 1234063003: Remove PopupMenuController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234063003: Remove PopupMenuController (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
jackson

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove PopupMenuController Rather than using a controller, the PopupMenu now takes input via its constructor. I'm not 100% happy with PopupMenuStatusChangedCallback, but we can continue to iterate. Also, fix the positioning of the menu to be correct. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/07b361071c306a9d3dbf5851a18937d5ce11d8f1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -93 lines)			Patch
M	sky/sdk/example/stocks/lib/stock_home.dart	View		2 chunks	+14 lines, -10 lines	0 comments	Download
M	sky/sdk/example/stocks/lib/stock_menu.dart	View		2 chunks	+13 lines, -8 lines	0 comments	Download
M	sky/sdk/lib/widgets/popup_menu.dart	View	1	3 chunks	+69 lines, -75 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-14 17:44:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
07b361071c306a9d3dbf5851a18937d5ce11d8f1 (presubmit successful).