chrome/browser/ui/android/snackbars/auto_signin_snackbar_controller_helper.h - Issue 1234063002: [Smart Lock] Auto sign-in snackbar UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/android/snackbars/auto_signin_snackbar_controller_helper.h

Issue 1234063002: [Smart Lock] Auto sign-in snackbar UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Dot in the licence disclaimer. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/password_manager/chrome_password_manager_client.cc ('K') | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/ui/android/snackbars/auto_signin_snackbar_controller_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_ANDROID_SNACKBARS_AUTO_SIGNIN_SNACKBAR_CONTROLLER_HELP ER_H_
	newt (away) 2015/08/21 16:47:32 How about naming this auto_signin_snackbar.h or au How about naming this auto_signin_snackbar.h or auto_signin_snackbar_controller.h? That seems sufficiently descriptive without being a mouthful. auto_signin_snackbar_controller.h is nice because it has the same name as the Java class, so it's easy for developers to figure out which cc files goes with the java file and vice versa. melandory 2015/08/21 19:04:10 Done. Show quoted text On 2015/08/21 16:47:32, newt wrote: > How about naming this auto_signin_snackbar.h or > auto_signin_snackbar_controller.h? That seems sufficiently descriptive without > being a mouthful. > > auto_signin_snackbar_controller.h is nice because it has the same name as the > Java class, so it's easy for developers to figure out which cc files goes with > the java file and vice versa. Done.
	6 #define CHROME_BROWSER_UI_ANDROID_SNACKBARS_AUTO_SIGNIN_SNACKBAR_CONTROLLER_HELP ER_H_

	7

	8 #include <jni.h>

	9

	10 #include "base/strings/string16.h"

	11

	12 class TabAndroid;

	13

	14 // Shows an auto sign-in snackbar in order to inform the users that they were

	15 // automatically signed in to the website. \|username\| is the username used by

	16 // the user in order to login to the web site, it can be email, telephone number

	17 // or any string.

	18 void ShowAutoSigninSnackbar(TabAndroid *tab, const base::string16& username);

	19

	20 // Register native method.

	21 bool RegisterAutoSigninSnackbarControllerHelper(JNIEnv* env);

	22

	23 #endif // CHROME_BROWSER_UI_ANDROID_SNACKBARS_AUTO_SIGNIN_SNACKBAR_CONTROLLER_HE LPER_H_

OLD	NEW