Plumb in an externally created v8::Isolate

fpdfsdk/src/javascript/JS_Runtime.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_EventHandler.h"
 #include "../../include/javascript/JS_Runtime.h"
@@ skipping 94 matching lines @@
 
 /* ------------------------------ CJS_Runtime ------------------------------ */
 
 CJS_Runtime::CJS_Runtime(CPDFDoc_Environment * pApp) :
         m_pApp(pApp),
         m_pDocument(NULL),
         m_bBlocking(FALSE),
         m_bRegistered(FALSE),
         m_pFieldEventPath(NULL)
 {
-        m_pArrayBufferAllocator.reset(new CJS_ArrayBufferAllocator());
+        if (m_pApp->GetFormFillInfo()->m_pJsPlatform->version == 2) {

[Tom Sepez, 2015/07/14 16:22:53]

I think we want >= 2 for future compatibility. Also, how about allowing callers
to pass a null m_isolate to get the current behaviour? 

+                m_isolate = m_pApp->GetFormFillInfo()->m_pJsPlatform->m_isolate;
+        } else {
+                m_pArrayBufferAllocator.reset(new CJS_ArrayBufferAllocator());
 
-        v8::Isolate::CreateParams params;
-        params.array_buffer_allocator = m_pArrayBufferAllocator.get();
-        m_isolate = v8::Isolate::New(params);
+                v8::Isolate::CreateParams params;
+                params.array_buffer_allocator = m_pArrayBufferAllocator.get();
+                m_isolate = v8::Isolate::New(params);
+        }
 
         InitJSObjects();
 
         CJS_Context * pContext = (CJS_Context*)NewContext();
         JS_InitialRuntime(*this, this, pContext, m_context);
         ReleaseContext(pContext);
 }
 
 CJS_Runtime::~CJS_Runtime()
 {
@@ skipping 202 matching lines @@
 {
         return v8::Local<v8::Context>::New(m_isolate, m_context);
 }
 
 CFX_WideString ChangeObjName(const CFX_WideString& str)
 {
         CFX_WideString sRet = str;
         sRet.Replace(L"_", L".");
         return sRet;
 }