Add Syzygy support to Windows GN build.

Add Syzygy support to Windows GN build.

BUG=511498
Committed: https://crrev.com/66e3feabd73622adccda533917c3441f6d0395a2
Cr-Commit-Position: refs/heads/master@{#339566}

[brettw, 2015-07-18 00:08:00]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-18 00:09:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234033005/1

[commit-bot: I haz the power, 2015-07-18 02:39:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-18 02:39:19]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-07-20 17:45:47]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-07-20 17:45:51]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 17:46:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234033005/40001

[commit-bot: I haz the power, 2015-07-20 18:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 18:28:51]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-07-20 19:29:41]

lgtm depending on the answer to the is_win question; if the answer isn't yes,
I'd like to discuss the options a bit more.

https://codereview.chromium.org/1234033005/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1234033005/diff/40001/BUILD.gn#newcode76
BUILD.gn:76: "//chrome/tools/build/win/syzygy:chrome_dll_syzygy",
shouldn't this be under is_win or something?

https://codereview.chromium.org/1234033005/diff/40001/chrome/tools/build/win/...
File chrome/tools/build/win/syzygy/BUILD.gn (right):

https://codereview.chromium.org/1234033005/diff/40001/chrome/tools/build/win/...
chrome/tools/build/win/syzygy/BUILD.gn:9: # Generate Syzygy optimized binaries.
it would be nice if there was some documentation somewhere of what the two flags
did and what the difference was.

[brettw, 2015-07-20 22:21:56]

https://codereview.chromium.org/1234033005/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1234033005/diff/40001/BUILD.gn#newcode76
BUILD.gn:76: "//chrome/tools/build/win/syzygy:chrome_dll_syzygy",
On 2015/07/20 19:29:41, Dirk Pranke wrote:
> shouldn't this be under is_win or something?

I explicitly made the targets exist in all cases because the conditions where
these do something is rather complicated (not even all the time on Windows).

https://codereview.chromium.org/1234033005/diff/40001/chrome/tools/build/win/...
File chrome/tools/build/win/syzygy/BUILD.gn (right):

https://codereview.chromium.org/1234033005/diff/40001/chrome/tools/build/win/...
chrome/tools/build/win/syzygy/BUILD.gn:9: # Generate Syzygy optimized binaries.
I added one more sentence in each of these places on what these things are.

[brettw, 2015-07-20 22:21:59]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-20 22:22:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1234033005/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-07-20 22:22:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234033005/60001

[brettw, 2015-07-20 22:26:08]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2015-07-20 23:12:49]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-20 23:12:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1234033005/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-07-20 23:13:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234033005/80001

[commit-bot: I haz the power, 2015-07-20 23:52:29]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-20 23:53:15]

Patchset 5 (id:??) landed as
https://crrev.com/66e3feabd73622adccda533917c3441f6d0395a2
Cr-Commit-Position: refs/heads/master@{#339566}