Issue 1234023003: [turbofan] Build graphs for super constructor calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234023003: [turbofan] Build graphs for super constructor calls. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger

Modified:
5 years, 5 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Build graphs for super constructor calls. This adapts JSCallConstruct nodes to represent both, ordinary 'new' constructor calls as well as 'super' constructor calls. Note that we still bailout for super calls for now. R=bmeurer@chromium.org Committed: https://crrev.com/9cf1c58145403ba63b7546dd3eff7ef80649acea Cr-Commit-Position: refs/heads/master@{#29647}

Patch Set 1 #

Patch Set 2 : Fix compilation in release mode. #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -11 lines)			Patch
M	src/compiler/ast-graph-builder.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/ast-graph-builder.cc	View		3 chunks	+45 lines, -7 lines	0 comments	Download
M	src/compiler/js-generic-lowering.cc	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234023003/20001

5 years, 5 months ago (2015-07-14 11:21:27 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-14 11:40:39 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/9cf1c58145403ba63b7546dd3eff7ef80649acea
Cr-Commit-Position: refs/heads/master@{#29647}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages