Source/modules/permissions/Permissions.h - Issue 1234023002: blink: permissions: add plumbing to revoke permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/permissions/Permissions.h

Issue 1234023002: blink: permissions: add plumbing to revoke permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add proper tests and fix Mounir's comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/permissions/PermissionQueryCallback.cpp ('k') | Source/modules/permissions/Permissions.cpp » ('j') | public/platform/modules/permissions/WebPermissionClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/permissions/Permissions.h

diff --git a/Source/modules/permissions/Permissions.h b/Source/modules/permissions/Permissions.h

index c7c1c4c5e095b32fc29f1f24c2f8f8bd8d8d9bb7..03a0394aa84e054de68d28d09a824e999297bc61 100644

--- a/Source/modules/permissions/Permissions.h

+++ b/Source/modules/permissions/Permissions.h

@@ -8,6 +8,7 @@

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptWrappable.h"

#include "platform/heap/Handle.h"

+#include "public/platform/modules/permissions/WebPermissionType.h"

mlamouri (slow - plz ping) 2015/07/20 14:14:12 nit: I think you can remove that header.

namespace blink {

@@ -22,6 +23,7 @@ public:

DEFINE_INLINE_TRACE() { }

ScriptPromise query(ScriptState*, const ScriptValue&);

+ ScriptPromise revoke(ScriptState*, const ScriptValue&);

};

} // namespace blink