Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: public/platform/modules/permissions/WebPermissionClient.h

Issue 1234023002: blink: permissions: add plumbing to revoke permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add Runtime flag for permissions Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/modules/permissions/WebPermissionClient.h
diff --git a/public/platform/modules/permissions/WebPermissionClient.h b/public/platform/modules/permissions/WebPermissionClient.h
index efc8811b81bb5f4f33b96c8a9b1edb567632bad7..e3f175cdd4a5171f6dde723cf7fab6733432579d 100644
--- a/public/platform/modules/permissions/WebPermissionClient.h
+++ b/public/platform/modules/permissions/WebPermissionClient.h
@@ -11,7 +11,7 @@
namespace blink {
-using WebPermissionQueryCallback = WebCallbacks<WebPermissionStatus, void>;
+using WebPermissionCallback = WebCallbacks<WebPermissionStatus, void>;
mlamouri (slow - plz ping) 2015/07/17 13:18:03 I think this change will break Chromium. You might
Lalit Maganti 2015/07/17 13:47:35 Done.
class WebPermissionObserver;
class WebURL;
@@ -21,7 +21,10 @@ class WebURL;
class WebPermissionClient {
public:
// Query the permission status of a given origin for a specific permission.
- virtual void queryPermission(WebPermissionType, const WebURL&, WebPermissionQueryCallback*) { }
+ virtual void queryPermission(WebPermissionType, const WebURL&, WebPermissionCallback*) { }
+
+ // Revoke a specific permission for a given origin.
+ virtual void revokePermission(WebPermissionType, const WebURL&, WebPermissionCallback*) { }
// Listen for permission changes for a given origin and inform the observer
// when they happen. The observer is not owned by the WebPermissionClient.
« Source/modules/permissions/Permissions.cpp ('K') | « Source/platform/RuntimeEnabledFeatures.in ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698