Chromium Code Reviews| Index: Source/modules/permissions/PermissionCallback.h |
| diff --git a/Source/modules/permissions/PermissionQueryCallback.h b/Source/modules/permissions/PermissionCallback.h |
| similarity index 75% |
| rename from Source/modules/permissions/PermissionQueryCallback.h |
| rename to Source/modules/permissions/PermissionCallback.h |
| index c5631582b2830013d8a202ab6087091da244a758..331b40eb14313b0c93d30b3c7007c44c0cdccfbb 100644 |
| --- a/Source/modules/permissions/PermissionQueryCallback.h |
| +++ b/Source/modules/permissions/PermissionCallback.h |
| @@ -2,8 +2,8 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| -#ifndef PermissionQueryCallback_h |
| -#define PermissionQueryCallback_h |
| +#ifndef PermissionCallback_h |
| +#define PermissionCallback_h |
| #include "platform/heap/Handle.h" |
| #include "public/platform/WebCallbacks.h" |
| @@ -17,15 +17,15 @@ namespace blink { |
| class ScriptPromiseResolver; |
| -// PermissionQueryCallback is an implementation of WebPermissionQueryCallbacks |
| +// PermissionQueryCallback is an implementation of WebPermissionCallbacks |
| // that will resolve the underlying promise depending on the result passed to |
| // the callback. It takes a WebPermissionType in its constructor and will pass |
| // it to the PermissionStatus. |
| -class PermissionQueryCallback final |
| +class PermissionCallback final |
| : public WebCallbacks<WebPermissionStatus, void> { |
| public: |
| - explicit PermissionQueryCallback(PassRefPtr<ScriptPromiseResolver>, WebPermissionType); |
|
mlamouri (slow - plz ping)
2015/07/17 13:16:18
nit: can you remove explicit as long as you are he
Lalit Maganti
2015/07/17 13:47:35
Done. I didn't actually know what the explicit key
mlamouri (slow - plz ping)
2015/07/20 14:14:12
The joys of backward compatibility :)
|
| - ~PermissionQueryCallback() override; |
| + explicit PermissionCallback(PassRefPtr<ScriptPromiseResolver>, WebPermissionType); |
| + ~PermissionCallback() override; |
| void onSuccess(WebPermissionStatus*) override; |
| void onError() override; |
| @@ -34,9 +34,9 @@ private: |
| RefPtr<ScriptPromiseResolver> m_resolver; |
| WebPermissionType m_permissionType; |
| - WTF_MAKE_NONCOPYABLE(PermissionQueryCallback); |
| + WTF_MAKE_NONCOPYABLE(PermissionCallback); |
| }; |
| } // namespace blink |
| -#endif // PermissionQueryCallback_h |
| +#endif // PermissionCallback_h |