blink: permissions: add plumbing to revoke permissions

Source/modules/permissions/Permissions.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/permissions/Permissions.h"
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/modules/v8/V8MidiPermissionDescriptor.h"
 #include "bindings/modules/v8/V8PermissionDescriptor.h"
 #include "bindings/modules/v8/V8PushPermissionDescriptor.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
+#include "modules/permissions/PermissionCallback.h"
 #include "modules/permissions/PermissionController.h"
 #include "modules/permissions/PermissionDescriptor.h"
-#include "modules/permissions/PermissionQueryCallback.h"
 #include "modules/permissions/PermissionStatus.h"
 #include "public/platform/Platform.h"
 #include "public/platform/modules/permissions/WebPermissionClient.h"
 
 namespace blink {
 
 namespace {
 
 WebPermissionClient* permissionClient(ExecutionContext* executionContext)
 {
     if (executionContext->isDocument()) {
         Document* document = toDocument(executionContext);
         if (!document->frame())
             return nullptr;
         PermissionController* controller = PermissionController::from(*document->frame());
         return controller ? controller->client() : nullptr;
     }
     return Platform::current()->permissionClient();
 }
 
+bool quickHandlePermissions(

[mlamouri (slow - plz ping), 2015/07/17 13:16:18]

Could you call that "handleDefaultBehaviour()" and add a comment that explains
what the method is doing.

[Lalit Maganti, 2015/07/17 13:47:35]

Done. The name you suggest is nice - I couldn't really think of one which summed
up the behavior. Also I'm not sure if my comment is 100% accurate.

+    ScriptState* scriptState, const ScriptValue& rawPermission, PassRefPtr<ScriptPromiseResolver> resolver, WebPermissionType type, TrackExceptionState& exceptionState)
+{
+    if (type == WebPermissionTypePushNotifications) {
+        PushPermissionDescriptor pushPermission = NativeValueTraits<PushPermissionDescriptor>::nativeValue(scriptState->isolate(), rawPermission.v8Value(), exceptionState);
+        // Only "userVisibleOnly" push is supported for now.
+        if (!pushPermission.userVisibleOnly()) {
+            resolver->reject(DOMException::create(NotSupportedError, "Push Permission without userVisibleOnly:true isn't supported yet."));
+            return true;
+        }
+    } else if (type == WebPermissionTypeMidiSysEx) {
+        MidiPermissionDescriptor midiPermission = NativeValueTraits<MidiPermissionDescriptor>::nativeValue(scriptState->isolate(), rawPermission.v8Value(), exceptionState);
+        // Only sysex usage requires a permission, otherwise it is granted.
+        if (!midiPermission.sysex()) {
+            resolver->resolve(PermissionStatus::create(scriptState->executionContext(), WebPermissionStatusGranted, WebPermissionTypeMidi));
+            return true;
+        }
+    }
+    return false;
+}
+
 } // anonymous namespace
 
 ScriptPromise Permissions::query(ScriptState* scriptState, const ScriptValue& rawPermission)
 {
     WebPermissionClient* client = permissionClient(scriptState->executionContext());
     if (!client)
         return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "In its current state, the global scope can't query permissions."));
 
     TrackExceptionState exceptionState;
     PermissionDescriptor permission = NativeValueTraits<PermissionDescriptor>::nativeValue(scriptState->isolate(), rawPermission.v8Value(), exceptionState);
 
 
     if (exceptionState.hadException())
         return ScriptPromise::reject(scriptState, v8::Exception::TypeError(v8String(scriptState->isolate(), exceptionState.message())));
 
     RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
 
     String name = permission.name();
-    WebPermissionType type;
-    if (name == "geolocation") {
-        type = WebPermissionTypeGeolocation;
-    } else if (name == "notifications") {
-        type = WebPermissionTypeNotifications;
-    } else if (name == "push") {
-        PushPermissionDescriptor pushPermission = NativeValueTraits<PushPermissionDescriptor>::nativeValue(scriptState->isolate(), rawPermission.v8Value(), exceptionState);
-        // Only "userVisibleOnly" push is supported for now.
-        if (!pushPermission.userVisibleOnly()) {
-            resolver->reject(DOMException::create(NotSupportedError, "Push Permission without userVisibleOnly:true isn't supported yet."));
-            return promise;
-        }
-        type = WebPermissionTypePushNotifications;
-    } else if (name == "midi") {
-        MidiPermissionDescriptor midiPermission = NativeValueTraits<MidiPermissionDescriptor>::nativeValue(scriptState->isolate(), rawPermission.v8Value(), exceptionState);
-        // Only sysex usage requires a permission, otherwise it is granted.
-        if (!midiPermission.sysex()) {
-            resolver->resolve(PermissionStatus::create(scriptState->executionContext(), WebPermissionStatusGranted, WebPermissionTypeMidi));
-            return promise;
-        }
-        type = WebPermissionTypeMidiSysEx;
-    } else {
-        ASSERT_NOT_REACHED();
-        type = WebPermissionTypeGeolocation;
-    }
+    WebPermissionType type = convertPermissionStringToType(name);
+    bool handled = quickHandlePermissions(scriptState, rawPermission, resolver, type, exceptionState);
+
+    if (handled)
+        return promise;

[mlamouri (slow - plz ping), 2015/07/17 13:16:18]

if (handleDefaultBehaviour(...))
    return promise;

[Lalit Maganti, 2015/07/17 13:47:35]

Done. This is a pattern I've got to get used to.

 
     // If the current origin is a file scheme, it will unlikely return a
     // meaningful value because most APIs are broken on file scheme and no
     // permission prompt will be shown even if the returned permission will most
     // likely be "prompt".
-    client->queryPermission(type, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionQueryCallback(resolver, type));
+    client->queryPermission(type, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionCallback(resolver, type));
     return promise;
 }
 
+ScriptPromise Permissions::revoke(ScriptState* scriptState, const ScriptValue& rawPermission)
+{
+    WebPermissionClient* client = permissionClient(scriptState->executionContext());
+    if (!client)
+        return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "In its current state, the global scope can't revoke permissions."));
+
+    TrackExceptionState exceptionState;
+    PermissionDescriptor permission = NativeValueTraits<PermissionDescriptor>::nativeValue(scriptState->isolate(), rawPermission.v8Value(), exceptionState);
+
+    if (exceptionState.hadException())
+        return ScriptPromise::reject(scriptState, v8::Exception::TypeError(v8String(scriptState->isolate(), exceptionState.message())));
+
+    RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();
+
+    String name = permission.name();
+    WebPermissionType type = convertPermissionStringToType(name);
+    bool handled = quickHandlePermissions(scriptState, rawPermission, resolver, type, exceptionState);
+
+    if (handled)
+        return promise;

[mlamouri (slow - plz ping), 2015/07/17 13:16:18]

ditto

[Lalit Maganti, 2015/07/17 13:47:35]

Done.

+
+    client->revokePermission(type, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionCallback(resolver, type));
+    return promise;
+}
+
+WebPermissionType Permissions::convertPermissionStringToType(const String& name)
+{
+    if (name == "geolocation")
+        return WebPermissionTypeGeolocation;
+    if (name == "notifications")
+        return WebPermissionTypeNotifications;
+    if (name == "push")
+        return WebPermissionTypePushNotifications;
+    if (name == "midi")
+        return WebPermissionTypeMidiSysEx;
+
+    ASSERT_NOT_REACHED();
+    return WebPermissionTypeGeolocation;
+}
+
 } // namespace blink