Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: runtime/vm/compiler.cc

Issue 12340108: Remove dead phis as soon as they are discovered. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | runtime/vm/flow_graph_allocator.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/code_generator.h" 10 #include "vm/code_generator.h"
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 174
175 FlowGraphOptimizer optimizer(flow_graph); 175 FlowGraphOptimizer optimizer(flow_graph);
176 optimizer.ApplyICData(); 176 optimizer.ApplyICData();
177 DEBUG_ASSERT(flow_graph->VerifyUseLists()); 177 DEBUG_ASSERT(flow_graph->VerifyUseLists());
178 178
179 // Optimize (a << b) & c patterns. Must occur before 179 // Optimize (a << b) & c patterns. Must occur before
180 // 'SelectRepresentations' which inserts conversion nodes. 180 // 'SelectRepresentations' which inserts conversion nodes.
181 // TODO(srdjan): Moved before inlining until environment use list can 181 // TODO(srdjan): Moved before inlining until environment use list can
182 // be used to detect when shift-left is outside the scope of bit-and. 182 // be used to detect when shift-left is outside the scope of bit-and.
183 optimizer.TryOptimizeLeftShiftWithBitAndPattern(); 183 optimizer.TryOptimizeLeftShiftWithBitAndPattern();
184 DEBUG_ASSERT(flow_graph->VerifyUseLists());
184 185
185 // Inlining (mutates the flow graph) 186 // Inlining (mutates the flow graph)
186 if (FLAG_use_inlining) { 187 if (FLAG_use_inlining) {
187 TimerScope timer(FLAG_compiler_stats, 188 TimerScope timer(FLAG_compiler_stats,
188 &CompilerStats::graphinliner_timer); 189 &CompilerStats::graphinliner_timer);
189 FlowGraphInliner inliner(flow_graph); 190 FlowGraphInliner inliner(flow_graph);
190 inliner.Inline(); 191 inliner.Inline();
191 // Use lists are maintained and validated by the inliner. 192 // Use lists are maintained and validated by the inliner.
192 DEBUG_ASSERT(flow_graph->VerifyUseLists()); 193 DEBUG_ASSERT(flow_graph->VerifyUseLists());
193 } 194 }
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 Object::Handle(isolate->object_store()->sticky_error()); 648 Object::Handle(isolate->object_store()->sticky_error());
648 isolate->object_store()->clear_sticky_error(); 649 isolate->object_store()->clear_sticky_error();
649 isolate->set_long_jump_base(base); 650 isolate->set_long_jump_base(base);
650 return result.raw(); 651 return result.raw();
651 } 652 }
652 UNREACHABLE(); 653 UNREACHABLE();
653 return Object::null(); 654 return Object::null();
654 } 655 }
655 656
656 } // namespace dart 657 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | runtime/vm/flow_graph_allocator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698