Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12340107: Remove some more web intents code I missed previously (Closed)

Created:
7 years, 9 months ago by Nico
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Raman Kakilate, groby+watch_chromium.org, benquan, dhollowa+watch_chromium.org, rouslan+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, chromium-apps-reviews_chromium.org, Aaron Boodman, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, gbillock+watch_chromium.org, estade+watch_chromium.org, smckay+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Remove some more web intents code I missed previously Thanks to Jochen for finding it. BUG=173194 TBR=tony Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184957

Patch Set 1 #

Patch Set 2 : cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1268 lines) Patch
M build/common.gypi View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 1 4 chunks +0 lines, -231 lines 0 comments Download
D chrome/browser/webdata/web_intents_table_unittest.cc View 1 chunk +0 lines, -373 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 3 chunks +0 lines, -11 lines 0 comments Download
D webkit/glue/web_intent_data.h View 1 chunk +0 lines, -107 lines 0 comments Download
D webkit/glue/web_intent_data.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D webkit/glue/web_intent_reply_data.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webkit/glue/web_intent_reply_data.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/glue/web_intent_reply_data_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D webkit/glue/web_intent_service_data.h View 1 chunk +0 lines, -68 lines 0 comments Download
D webkit/glue/web_intent_service_data.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D webkit/glue/web_intent_service_data_unittest.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
7 years, 9 months ago (2013-02-27 13:20:57 UTC) #1
Nico
7 years, 9 months ago (2013-02-27 13:21:08 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years, 9 months ago (2013-02-27 13:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12340107/1
7 years, 9 months ago (2013-02-27 13:28:16 UTC) #4
commit-bot: I haz the power
Presubmit check for 12340107-1 failed and returned exit status 1. INFO:root:Found 5 file(s). Running presubmit ...
7 years, 9 months ago (2013-02-27 13:28:24 UTC) #5
Nico
tony: webkit/ TBR
7 years, 9 months ago (2013-02-27 13:29:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12340107/1
7 years, 9 months ago (2013-02-27 13:29:24 UTC) #7
commit-bot: I haz the power
Failed to trigger a try job on linux_chromeos HTTP Error 400: Bad Request
7 years, 9 months ago (2013-02-27 13:42:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12340107/2006
7 years, 9 months ago (2013-02-27 13:42:20 UTC) #9
Nico
7 years, 9 months ago (2013-02-27 15:29:50 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 manually as r184957 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698