Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate

chrome/browser/ui/autofill/tab_autofill_manager_delegate.h

Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
index 141c9758fc917f79dcf91de268ea8a04ad4dfbed..599554b756f5a5463d8b24b361eb963f9493d1b2 100644
--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
@@ -6,11 +6,14 @@
 #define CHROME_BROWSER_UI_AUTOFILL_TAB_AUTOFILL_MANAGER_DELEGATE_H_
 
 #include "base/compiler_specific.h"
+#include "base/memory/weak_ptr.h"
 #include "chrome/browser/autofill/autofill_manager_delegate.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 
+class AutofillPopupControllerImpl;
+
 namespace content {
 struct FrameNavigateParams;
 struct LoadCommittedDetails;
@@ -27,7 +30,7 @@ class TabAutofillManagerDelegate
       public content::WebContentsUserData<TabAutofillManagerDelegate>,
       public content::WebContentsObserver {
  public:
-  virtual ~TabAutofillManagerDelegate() {}
+  virtual ~TabAutofillManagerDelegate();
 
   // AutofillManagerDelegate implementation.
   virtual InfoBarService* GetInfoBarService() OVERRIDE;
@@ -54,6 +57,13 @@ class TabAutofillManagerDelegate
       DialogType dialog_type,
       const base::Callback<void(const FormStructure*)>& callback) OVERRIDE;
   virtual void RequestAutocompleteDialogClosed() OVERRIDE;
+  virtual void ShowAutofillPopup(const gfx::RectF& element_bounds,
+                                 const std::vector<string16>& values,
+                                 const std::vector<string16>& labels,
+                                 const std::vector<string16>& icons,
+                                 const std::vector<int>& identifiers,
+                                 AutofillPopupDelegate* delegate) OVERRIDE;
+  virtual void HideAutofillPopup() OVERRIDE;
   virtual void UpdateProgressBar(double value) OVERRIDE;
 
   // content::WebContentsObserver implementation.
@@ -67,6 +77,7 @@ class TabAutofillManagerDelegate
 
   content::WebContents* const web_contents_;
   AutofillDialogControllerImpl* autofill_dialog_controller_;  // weak.
+  base::WeakPtr<AutofillPopupControllerImpl> autofill_popup_controller_;

[Ilya Sherman, 2013/02/26 02:12:15]

Optional nit: I'd omit the "autofill_" prefix here, i.e. just name this variable
"popup_controller".

[kaiwang, 2013/02/26 05:24:12]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(TabAutofillManagerDelegate);
 };