Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate

chrome/browser/autofill/autofill_external_delegate.h

Index: chrome/browser/autofill/autofill_external_delegate.h
diff --git a/chrome/browser/autofill/autofill_external_delegate.h b/chrome/browser/autofill/autofill_external_delegate.h
index d370bb0a9c0d20ac276fae231291387394f3dd92..f7d5f5b17d04fba361b34b069f4c72749c35ea4e 100644
--- a/chrome/browser/autofill/autofill_external_delegate.h
+++ b/chrome/browser/autofill/autofill_external_delegate.h
@@ -110,23 +110,8 @@ class AutofillExternalDelegate
                            AutofillManager* autofill_manager);
   virtual ~AutofillExternalDelegate();
 
-  // Displays the Autofill results to the user with an external Autofill popup
-  // that lives completely in the browser.  The suggestions have been correctly
-  // formatted by this point.
-  virtual void ApplyAutofillSuggestions(
-      const std::vector<string16>& autofill_values,
-      const std::vector<string16>& autofill_labels,
-      const std::vector<string16>& autofill_icons,
-      const std::vector<int>& autofill_unique_ids);
-
-  // Create the popup if it doesn't already exist. |element_bounds| is the
-  // bounding rect for the element it is popping up for.
-  virtual void EnsurePopupForElement(const gfx::RectF& element_bounds);
-
   content::WebContents* web_contents() { return web_contents_; }
 
-  AutofillPopupControllerImpl* controller() { return controller_; }
-
  private:
   // Fills the form with the Autofill data corresponding to |unique_id|.
   // If |is_preview| is true then this is just a preview to show the user what
@@ -163,7 +148,6 @@ class AutofillExternalDelegate
   // The web_contents associated with this delegate.
   content::WebContents* web_contents_;  // weak; owns me.
   AutofillManager* autofill_manager_;  // weak.
-  base::WeakPtr<AutofillPopupControllerImpl> controller_;
 
   // Password Autofill manager, handles all password-related Autofilling.
   PasswordAutofillManager password_autofill_manager_;
@@ -179,6 +163,9 @@ class AutofillExternalDelegate
   FormData autofill_query_form_;
   FormFieldData autofill_query_field_;
 
+  // The current bounding of Autofill popup.

[Ilya Sherman, 2013/02/26 02:12:15]

nit: These bounds are for the form field that the user is interacting with, not
the Autofill popup.

[kaiwang, 2013/02/26 05:24:12]

Done.

+  gfx::RectF autofill_popup_bounding_;

[Ilya Sherman, 2013/02/26 02:12:15]

nit: Please name this "element_bounds_".

[kaiwang, 2013/02/26 05:24:12]

Done.

+
   // Should we display a warning if Autofill is disabled?
   bool display_warning_if_disabled_;