Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: runtime/vm/assembler_arm.h

Issue 12340050: Add DISALLOW_COPY_AND_ASSIGN to subclasses of ValueObject and make ValueObject copyable. Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler.h ('k') | runtime/vm/assembler_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.h
===================================================================
--- runtime/vm/assembler_arm.h (revision 18957)
+++ runtime/vm/assembler_arm.h (working copy)
@@ -75,17 +75,6 @@
// Data-processing operands - Uninitialized.
ShifterOperand() : type_(-1), encoding_(-1) { }
- // Data-processing operands - Copy constructor.
- ShifterOperand(const ShifterOperand& other)
- : ValueObject(), type_(other.type_), encoding_(other.encoding_) { }
-
- // Data-processing operands - Assignment operator.
- ShifterOperand& operator=(const ShifterOperand& other) {
- type_ = other.type_;
- encoding_ = other.encoding_;
- return *this;
- }
-
// Data-processing operands - Immediate.
explicit ShifterOperand(uint32_t immediate) {
ASSERT(immediate < (1 << kImmed8Bits));
@@ -211,13 +200,6 @@
NegPostIndex = (0|0|0) << 21 // negative post-indexed with writeback
};
- Address(const Address& other) : ValueObject(), encoding_(other.encoding_) { }
-
- Address& operator=(const Address& other) {
- encoding_ = other.encoding_;
- return *this;
- }
-
explicit Address(Register rn, int32_t offset = 0, Mode am = Offset) {
ASSERT(Utils::IsAbsoluteUint(12, offset));
if (offset < 0) {
@@ -250,13 +232,6 @@
public:
FieldAddress(Register base, int32_t disp)
: Address(base, disp - kHeapObjectTag) { }
-
- FieldAddress(const FieldAddress& other) : Address(other) { }
-
- FieldAddress& operator=(const FieldAddress& other) {
- Address::operator=(other);
- return *this;
- }
};
@@ -638,7 +613,6 @@
return *reg1 - *reg2;
}
- DISALLOW_ALLOCATION();
DISALLOW_COPY_AND_ASSIGN(Assembler);
};
« no previous file with comments | « runtime/vm/assembler.h ('k') | runtime/vm/assembler_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698