Add DISALLOW_COPY_AND_ASSIGN to subclasses of ValueObject and make ValueObject copyable.

runtime/vm/intermediate_language.h

Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h	(revision 18957)
+++ runtime/vm/intermediate_language.h	(working copy)
@@ -118,19 +118,6 @@
   static const bool kNullable = true;
   static const bool kNonNullable = false;
 
-  CompileType(const CompileType& other)
-      : ValueObject(),
-        is_nullable_(other.is_nullable_),
-        cid_(other.cid_),
-        type_(other.type_) { }
-
-  CompileType& operator=(const CompileType& other) {
-    is_nullable_ = other.is_nullable_;
-    cid_ = other.cid_;
-    type_ =  other.type_;
-    return *this;
-  }
-
   // Return type such that concrete value's type in runtime is guaranteed to
   // be subtype of it.
   const AbstractType* ToAbstractType();
@@ -1023,6 +1010,8 @@
  private:
   BlockEntryInstr* block_entry_;
   Instruction* current_;
+
+  DISALLOW_COPY_AND_ASSIGN(ForwardInstructionIterator);
 };
 
 
@@ -1045,6 +1034,8 @@
  private:
   BlockEntryInstr* block_entry_;
   Instruction* current_;
+
+  DISALLOW_COPY_AND_ASSIGN(BackwardInstructionIterator);
 };
 
 
@@ -1172,6 +1163,8 @@
  private:
   ZoneGrowableArray<PhiInstr*>* phis_;
   intptr_t index_;
+
+  DISALLOW_COPY_AND_ASSIGN(PhiIterator);
 };
 
 
@@ -1805,19 +1798,6 @@
 
   RangeBoundary() : kind_(kUnknown), value_(0), offset_(0) { }
 
-  RangeBoundary(const RangeBoundary& other)
-      : ValueObject(),
-        kind_(other.kind_),
-        value_(other.value_),
-        offset_(other.offset_) { }
-
-  RangeBoundary& operator=(const RangeBoundary& other) {
-    kind_ = other.kind_;
-    value_ = other.value_;
-    offset_ = other.offset_;
-    return *this;
-  }
-
   static RangeBoundary FromConstant(intptr_t val) {
     return RangeBoundary(kConstant, val, 0);
   }
@@ -4332,17 +4312,6 @@
     explicit ShallowIterator(Environment* environment)
         : environment_(environment), index_(0) { }
 
-    ShallowIterator(const ShallowIterator& other)
-        : ValueObject(),
-          environment_(other.environment_),
-          index_(other.index_) { }
-
-    ShallowIterator& operator=(const ShallowIterator& other) {
-      environment_ = other.environment_;
-      index_ = other.index_;
-      return *this;
-    }
-
     Environment* environment() const { return environment_; }
 
     void Advance() {
@@ -4425,6 +4394,8 @@
     }
 
     ShallowIterator iterator_;
+
+    DISALLOW_COPY_AND_ASSIGN(DeepIterator);
   };
 
   // Construct an environment by constructing uses from an array of definitions.