Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 12340032: Merge 142927 (Closed)

Created:
7 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 142927 > [chromium] No triggering autofill on unfocus > https://bugs.webkit.org/show_bug.cgi?id=109735 > > Patch by David Trainor <dtrainor@chromium.org>; on 2013-02-14 > Reviewed by James Robinson. > > Need to notify the autofill client to not process text changes when we're setting > focus to false and are trying to commit a composition. > > * public/WebAutofillClient.h: > (WebAutofillClient): > (WebKit::WebAutofillClient::setIgnoreTextChanges): > (WebKit::WebAutofillClient::~WebAutofillClient): > * src/WebViewImpl.cpp: > (WebKit::WebViewImpl::setFocus): > * tests/WebViewTest.cpp: TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143776

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -2 lines) Patch
M Source/WebKit/chromium/ChangeLog View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/public/WebAutofillClient.h View 1 chunk +4 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M Source/WebKit/chromium/tests/WebViewTest.cpp View 2 chunks +93 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aelias_OOO_until_Jul13
7 years, 10 months ago (2013-02-22 20:31:56 UTC) #1
aelias_OOO_until_Jul13
7 years, 10 months ago (2013-02-22 20:32:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143776.

Powered by Google App Engine
This is Rietveld 408576698