Fix GnubbyAuthHandlerPosix to handle requests correctly.

remoting/host/gnubby_socket.cc

Index: remoting/host/gnubby_socket.cc
diff --git a/remoting/host/gnubby_socket.cc b/remoting/host/gnubby_socket.cc
index 7df45148a96a0ebc799f1de1cb68ee0b099f9c42..56f75c3831699571f52511064113b5818659454f 100644
--- a/remoting/host/gnubby_socket.cc
+++ b/remoting/host/gnubby_socket.cc
@@ -108,8 +108,9 @@ void GnubbySocket::DoWrite() {
 void GnubbySocket::OnDataRead(int bytes_read) {
   DCHECK(CalledOnValidThread());
 
-  if (bytes_read < 0) {
-    LOG(ERROR) << "Error in reading request.";
+  if (bytes_read <= 0) {
+    if (bytes_read < 0)
+      LOG(ERROR) << "Error in reading request.";

[Sergey Ulanov, 2015/07/16 23:20:54]

log the error code?

[Wez, 2015/07/17 20:51:19]

Done.

     read_completed_ = true;
     request_received_callback_.Run();

[Sergey Ulanov, 2015/07/16 23:20:54]

This should be base::ResetAndReturn(request_received_callback_).Run();
Otherwise request_received_callback_ can be modified while being called, which
is not safe (particularly it breaks when there are curried parameters passed by
reference).
Same in line 123

[Wez, 2015/07/17 20:51:20]

Done. Thanks for catching that!

     return;