Fix GnubbyAuthHandlerPosix to handle requests correctly.

Fix GnubbyAuthHandlerPosix to handle requests correctly.

Recent refactoring of GnubbyAuthHandlerPosix had assumed that requests
were handled synchronously, and that only one request should be handled
per connection, neither of which is the case.

BUG=509131
Committed: https://crrev.com/4cce0d79f1aa32fbaec58b7d2d04aefa92de72f7
Cr-Commit-Position: refs/heads/master@{#339555}

[Wez, 2015-07-14 01:20:03]

wez@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Wez, 2015-07-14 01:20:04]

PTAL

[Wez, 2015-07-16 23:04:36]

On 2015/07/14 01:20:04, Wez wrote:
> PTAL

Ping!

[Sergey Ulanov, 2015-07-16 23:20:54]

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_auth_h...
File remoting/host/gnubby_auth_handler_posix.cc (right):

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_auth_h...
remoting/host/gnubby_auth_handler_posix.cc:243: active_sockets_.erase(iter);
I think this can be moved in SendErrorAndCloseActiveSocket() and Close() can be
removed.

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_socket.cc
File remoting/host/gnubby_socket.cc (right):

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_socket...
remoting/host/gnubby_socket.cc:75: 
DCHECK(!request_received_callback_);

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_socket...
remoting/host/gnubby_socket.cc:113: LOG(ERROR) << "Error in reading request.";
log the error code?

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_socket...
remoting/host/gnubby_socket.cc:115: request_received_callback_.Run();
This should be base::ResetAndReturn(request_received_callback_).Run();
Otherwise request_received_callback_ can be modified while being called, which
is not safe (particularly it breaks when there are curried parameters passed by
reference).
Same in line 123

[Wez, 2015-07-17 20:51:20]

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_auth_h...
File remoting/host/gnubby_auth_handler_posix.cc (right):

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_auth_h...
remoting/host/gnubby_auth_handler_posix.cc:243: active_sockets_.erase(iter);
On 2015/07/16 23:20:54, Sergey Ulanov wrote:
> I think this can be moved in SendErrorAndCloseActiveSocket() and Close() can
be
> removed.

Done.

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_socket.cc
File remoting/host/gnubby_socket.cc (right):

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_socket...
remoting/host/gnubby_socket.cc:75: 
On 2015/07/16 23:20:54, Sergey Ulanov wrote:
> DCHECK(!request_received_callback_);

Done.

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_socket...
remoting/host/gnubby_socket.cc:113: LOG(ERROR) << "Error in reading request.";
On 2015/07/16 23:20:54, Sergey Ulanov wrote:
> log the error code?

Done.

https://codereview.chromium.org/1234003002/diff/1/remoting/host/gnubby_socket...
remoting/host/gnubby_socket.cc:115: request_received_callback_.Run();
On 2015/07/16 23:20:54, Sergey Ulanov wrote:
> This should be base::ResetAndReturn(request_received_callback_).Run();
> Otherwise request_received_callback_ can be modified while being called, which
> is not safe (particularly it breaks when there are curried parameters passed
by
> reference).
> Same in line 123

Done. Thanks for catching that!

[Sergey Ulanov, 2015-07-20 17:07:33]

lgtm

[Wez, 2015-07-20 19:16:35]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2015-07-20 19:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 19:17:27]

This CL has an open dependency (Issue 1230823006 Patch 1). Please resolve the
dependency and try again.

[Wez, 2015-07-20 21:57:42]

The CQ bit was checked by wez@chromium.org

[Wez, 2015-07-20 21:57:42]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1234003002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-07-20 21:58:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234003002/40001

[commit-bot: I haz the power, 2015-07-20 23:20:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-20 23:21:53]

Patchset 3 (id:??) landed as
https://crrev.com/4cce0d79f1aa32fbaec58b7d2d04aefa92de72f7
Cr-Commit-Position: refs/heads/master@{#339555}