Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12340017: Revert 183647 (Closed)

Created:
7 years, 10 months ago by kerz_chromium
Modified:
7 years, 10 months ago
Reviewers:
zel
CC:
chromium-reviews, nkostylev+watch_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 183647 > Merge 182894 > > Added interstitial page for merge session. This page will let us delay loading of Google properties during ChromeOS cookie session restore at login (aka /MergeSession). > > > > The interstitial page will show 3 seconds of no UI (white tab) followed with up to 7 seconds of UI with only "Loading..." message showing in tabs. For huge majority of cases, that secondary UI won't show since merge session will probably complete by then. > > > > BUG=171980 > > TEST=added merge_session_load_page_unittest.cc > > TBR=sky > > > > Review URL: https://codereview.chromium.org/12256046 > > TBR=zelidrag@chromium.org > Review URL: https://codereview.chromium.org/12319034 TBR=zelidrag@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -652 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 3 chunks +0 lines, -7 lines 0 comments Download
D chrome/browser/chromeos/login/merge_session_load_page.h View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/chromeos/login/merge_session_load_page.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/chromeos/login/merge_session_load_page_unittest.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D chrome/browser/chromeos/login/merge_session_throttle.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/chromeos/login/merge_session_throttle.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/oauth_login_manager.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 2 chunks +1 line, -21 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/browser/resources/chromeos/merge_session_load.html View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kerz_chromium
7 years, 10 months ago (2013-02-22 02:22:58 UTC) #1
kerz_chromium
7 years, 10 months ago (2013-02-22 02:23:13 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r183979.

Powered by Google App Engine
This is Rietveld 408576698