Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 12340008: Move extensibility check to the top of Object.isFrozen/Object.isSealed (Closed)

Created:
7 years, 10 months ago by adamk
Modified:
7 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev, rafaelw
Visibility:
Public.

Description

Move extensibility check to the top of Object.isFrozen/Object.isSealed This speeds up isFrozen/isSealed checks on "normal" objects without slowing down checks on frozen/sealed objects. Though this ordering is not what ES5 specifies, the difference is not observable (especially since the code bails out if the passed-in object is a proxy). Committed: https://code.google.com/p/v8/source/detail?r=13726

Patch Set 1 #

Patch Set 2 : Call %IsExtensible directly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/v8natives.js View 1 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
7 years, 10 months ago (2013-02-21 18:31:09 UTC) #1
rossberg
lgtm
7 years, 10 months ago (2013-02-25 10:39:35 UTC) #2
adamk
7 years, 10 months ago (2013-02-25 19:44:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13726 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698