Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: chrome/browser/mac/keystone_glue.mm

Issue 1233983004: Remove base/mac/scoped_nsexception_enabler.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/mac/keystone_glue.mm
diff --git a/chrome/browser/mac/keystone_glue.mm b/chrome/browser/mac/keystone_glue.mm
index f125fdfc73eb6ab15ca1c6d4aae910fd7ec83f72..e1d2db5ee5441ad14c15239b8820e8e13dd2fcd7 100644
--- a/chrome/browser/mac/keystone_glue.mm
+++ b/chrome/browser/mac/keystone_glue.mm
@@ -18,7 +18,6 @@
#include "base/mac/foundation_util.h"
#include "base/mac/mac_logging.h"
#include "base/mac/scoped_nsautorelease_pool.h"
-#include "base/mac/scoped_nsexception_enabler.h"
#include "base/memory/ref_counted.h"
#include "base/strings/sys_string_conversions.h"
#include "base/threading/worker_pool.h"
@@ -542,14 +541,7 @@ NSString* const kVersionKey = @"KSVersion";
[self updateStatus:kAutoupdateRegistering version:nil];
NSDictionary* parameters = [self keystoneParameters];
- BOOL result;
- {
- // TODO(shess): Allows Keystone to throw an exception when
- // /usr/bin/python does not exist (really!).
- // http://crbug.com/86221 and http://crbug.com/87931
- base::mac::ScopedNSExceptionEnabler enabler;
- result = [registration_ registerWithParameters:parameters];
- }
+ BOOL result = [registration_ registerWithParameters:parameters];
if (!result) {
[self updateStatus:kAutoupdateRegisterFailed version:nil];
return;

Powered by Google App Engine
This is Rietveld 408576698