Issue 1233983002: Rename MenuItem to DrawerItem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1233983002: Rename MenuItem to DrawerItem (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Rename MenuItem to DrawerItem .. and MenuDivider to DrawerDivider. These widgets are specific to Drawer. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c88ac9f8a48347cbf0e0e3d76db07bdca633e50c

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -154 lines)			Patch
M	sky/sdk/BUILD.gn	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/example/fitness/lib/home.dart	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	sky/sdk/example/fitness/lib/settings.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/sdk/example/stocks/lib/stock_home.dart	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	sky/sdk/example/stocks/lib/stock_settings.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A +	sky/sdk/lib/widgets/drawer_divider.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sky/sdk/lib/widgets/drawer_item.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	sky/sdk/lib/widgets/menu_divider.dart	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	sky/sdk/lib/widgets/menu_item.dart	View	1 chunk	+0 lines, -98 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

Committed patchset #1 (id:1) manually as c88ac9f8a48347cbf0e0e3d76db07bdca633e50c (presubmit successful).

5 years, 5 months ago (2015-07-13 23:56:04 UTC) #2

Message was sent while issue was closed.

lgtm