Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 1233983002: Rename MenuItem to DrawerItem (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename MenuItem to DrawerItem .. and MenuDivider to DrawerDivider. These widgets are specific to Drawer. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c88ac9f8a48347cbf0e0e3d76db07bdca633e50c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -154 lines) Patch
M sky/sdk/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/example/fitness/lib/home.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M sky/sdk/example/fitness/lib/settings.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_home.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_settings.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sky/sdk/lib/widgets/drawer_divider.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/lib/widgets/drawer_item.dart View 2 chunks +3 lines, -3 lines 0 comments Download
D sky/sdk/lib/widgets/menu_divider.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D sky/sdk/lib/widgets/menu_item.dart View 1 chunk +0 lines, -98 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-13 23:55:53 UTC) #1
abarth-chromium
Committed patchset #1 (id:1) manually as c88ac9f8a48347cbf0e0e3d76db07bdca633e50c (presubmit successful).
5 years, 5 months ago (2015-07-13 23:56:04 UTC) #2
Hixie
5 years, 5 months ago (2015-07-14 00:02:39 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698