src/processor/exploitability_unittest.cc - Issue 1233973002: Add ELF header analysis when checking for instruction pointer in code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/processor/exploitability_unittest.cc

Issue 1233973002: Add ELF header analysis when checking for instruction pointer in code. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/processor/exploitability_linux.h ('K') | « src/processor/exploitability_linux.cc ('k') | src/processor/testdata/linux_in_module_outside_executable_part.dmp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/processor/exploitability_unittest.cc

===================================================================

--- src/processor/exploitability_unittest.cc (revision 1471)

+++ src/processor/exploitability_unittest.cc (working copy)

@@ -119,6 +119,18 @@

ExploitabilityFor("linux_null_dereference.dmp"));

ASSERT_EQ(google_breakpad::EXPLOITABILITY_HIGH,

ExploitabilityFor("linux_jmp_to_0.dmp"));

+ ASSERT_EQ(google_breakpad::EXPLOITABILITY_HIGH,

+ ExploitabilityFor("linux_inside_elf_header.dmp"));

+ ASSERT_EQ(google_breakpad::EXPLOITABILITY_HIGH,

+ ExploitabilityFor("linux_outside_module.dmp"));

+ ASSERT_EQ(google_breakpad::EXPLOITABILITY_NONE,

+ ExploitabilityFor("linux_raise_sigabrt.dmp"));

+ ASSERT_EQ(google_breakpad::EXPLOITABILITY_HIGH,

+ ExploitabilityFor("linux_in_module_outside_executable_part.dmp"));

+ ASSERT_EQ(google_breakpad::EXPLOITABILITY_INTERESTING,

+ ExploitabilityFor("linux_inside_module_exe_region1.dmp"));

+ ASSERT_EQ(google_breakpad::EXPLOITABILITY_INTERESTING,

+ ExploitabilityFor("linux_inside_module_exe_region2.dmp"));

}